[Mesa-dev] [PATCH 0/7] Fixes for SW:KotOR (v2)
Matt Turner
mattst88 at gmail.com
Fri Feb 5 23:11:42 UTC 2016
Thanks a ton for contributing this. This is really cool.
I've replied to a couple of patches with a lot of style comments.
These issues appear in a lot of places I didn't point out (it was
getting a bit repetitive). A summary is
- Use spaces around operators
- Use BSD-style function declarations, with qualifiers and return
type on their own line
- Align line-wrapped arguments and parameters with the open paranthesis
- Use braces in nested if-statements
- Don't indent case/default labels past switch()
- Don't add code that is commented out
- Use spaces, not tabs
Thanks. I look forward to porting this to NIR and adding i965 support
at some point. :)
More information about the mesa-dev
mailing list