[Mesa-dev] [PATCH 0/7] Fixes for SW:KotOR (v2)

[Miklós Máté]

On 02/06/2016 12:11 AM, Matt Turner wrote:
> Thanks a ton for contributing this. This is really cool.
>
> I've replied to a couple of patches with a lot of style comments.
> These issues appear in a lot of places I didn't point out (it was
> getting a bit repetitive). A summary is
>
>   - Use spaces around operators
>   - Use BSD-style function declarations, with qualifiers and return
> type on their own line
>   - Align line-wrapped arguments and parameters with the open paranthesis
>   - Use braces in nested if-statements
>   - Don't indent case/default labels past switch()
>   - Don't add code that is commented out
>   - Use spaces, not tabs
>
> Thanks. I look forward to porting this to NIR and adding i965 support
> at some point. :)
Thanks for your thorough review. I started working on fixing the coding 
style to match the project.
However, I have to argue with you on main/state.c (in 1/7): I created 
that code with copy&paste, so the
usage of tabs and the && placement matches the style of the other if 
blocks in that function. Should I
fix them all?

MM