I was just messing with warning flags on virglrenderer and noticed -Wshadow generated a fair few warnings with gallium, so I did a mesa build with -Wshadow enabled and it was fairly messy, do we care? there could be bugs hiding in -Wshadow land. Dave.