[Mesa-dev] [PATCH 2/5] android: radeonsi: fix building error in si_shader.c

[Michel Dänzer]

On 14.02.2016 23:41, Mauro Rossi wrote:
> 
> From: Mauro Rossi <issor.oruam at gmail.com <mailto:issor.oruam at gmail.com>>
> Date: Sun, 14 Feb 2016 15:34:16 +0100
> Subject: [PATCH 1/2] android: add support for strchrnul
> 
> Android Bionic has no strchrnul in string functions,
> radeonsi uses strchrnul, so we need an implementation.
> 
> strchrnul.h is added in top mesa include path.

Gallium code (at least outside of src/gallium/state_trackers) is not
supposed to include headers from the toplevel include directory. This
header should be in src/util/ instead.


> +/**************************************************************************
> + *
> + * Copyright (C) 2014 Emil Velikov <emil.l.velikov at gmail.com
> <mailto:emil.l.velikov at gmail.com>>

Why Emil's copyright?


> +char *
> +strchrnul(const char *s, int c)
> +{
> +        char * result = strchr(s, c);

No space after the asterisk:

        char *result = strchr(s, c);


> From: Mauro Rossi <issor.oruam at gmail.com <mailto:issor.oruam at gmail.com>>
> Date: Sun, 14 Feb 2016 15:10:16 +0100
> Subject: [PATCH 2/2] android: radeonsi: fix building error in si_shader.c

With the shortlog changed to something along the lines of

 radeonsi: Fix strchrnul being undefined on Android

this patch is

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer