[Mesa-dev] [PATCH 2/5] android: radeonsi: fix building error in si_shader.c

[Emil Velikov]

On 16 February 2016 at 07:02, Michel Dänzer <michel at daenzer.net> wrote:
> On 14.02.2016 23:41, Mauro Rossi wrote:
>>
>> From: Mauro Rossi <issor.oruam at gmail.com <mailto:issor.oruam at gmail.com>>
>> Date: Sun, 14 Feb 2016 15:34:16 +0100
>> Subject: [PATCH 1/2] android: add support for strchrnul
>>
>> Android Bionic has no strchrnul in string functions,
>> radeonsi uses strchrnul, so we need an implementation.
>>
>> strchrnul.h is added in top mesa include path.
>
> Gallium code (at least outside of src/gallium/state_trackers) is not
> supposed to include headers from the toplevel include directory. This
> header should be in src/util/ instead.
>
If we consider this a compatibility wrapper then include/ is fine
(alongside a name like gnu_string.h). Although I'm thinking about a
shorter fix -> s/strchrnul/util_strchrnul/. Gallium already has (and
uses) an util function.

-Emil