[Mesa-dev] [PATCH 01/22] i965/meta: Delete unused layer shader uniform

Iago Toral itoral at igalia.com
Thu Feb 18 15:38:40 UTC 2016


I sent minor comments to patches 3 and 4. I think you should fix the
commit log for the latter at least. Otherwise, patches 1-6 are:

Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

On Wed, 2016-02-17 at 17:57 -0800, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> 
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> index 488fa6c..00c59f3 100644
> --- a/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> +++ b/src/mesa/drivers/dri/i965/brw_meta_fast_clear.c
> @@ -110,7 +110,6 @@ brw_bind_rep_write_shader(struct brw_context *brw, float *color)
>        "#extension GL_AMD_vertex_shader_layer : enable\n"
>        "#extension GL_ARB_draw_instanced : enable\n"
>        "attribute vec4 position;\n"
> -      "uniform int layer;\n"
>        "void main()\n"
>        "{\n"
>        "#ifdef GL_AMD_vertex_shader_layer\n"




More information about the mesa-dev mailing list