[Mesa-dev] [PATCH 5/5] nvc0: rename 3d binding points to NVC0_BIND_3D_XXX

[Samuel Pitoiset]

On 02/22/2016 12:08 AM, Ilia Mirkin wrote:
> On Sun, Feb 21, 2016 at 9:18 AM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>>
>>   /* 3d bufctx (during draw_vbo, blit_3d) */
>> -#define NVC0_BIND_FB            0
>> -#define NVC0_BIND_VTX           1
>> -#define NVC0_BIND_VTX_TMP       2
>> -#define NVC0_BIND_IDX           3
>> -#define NVC0_BIND_TEX(s, i)  (  4 + 32 * (s) + (i))
>> -#define NVC0_BIND_CB(s, i)   (164 + 16 * (s) + (i))
>> -#define NVC0_BIND_TFB         244
>> -#define NVC0_BIND_SUF         245
>> -#define NVC0_BIND_BUF         246
>> -#define NVC0_BIND_SCREEN      247
>> -#define NVC0_BIND_TLS         249
>> -#define NVC0_BIND_3D_COUNT    250
>> +#define NVC0_BIND_3D_FB            0
>> +#define NVC0_BIND_3D_VTX           1
>> +#define NVC0_BIND_3D_VTX_TMP       2
>> +#define NVC0_BIND_3D_IDX           3
>> +#define NVC0_BIND_3D_TEX(s, i)  (  4 + 32 * (s) + (i))
>> +#define NVC0_BIND_3D_CB(s, i)   (164 + 16 * (s) + (i))
>> +#define NVC0_BIND_3D_TFB         244
>> +#define NVC0_BIND_3D_SUF         245
>> +#define NVC0_BIND_3D_BUF         246
>> +#define NVC0_BIND_3D_SCREEN      247
>> +#define NVC0_BIND_3D_TLS         249
>> +#define NVC0_BIND_3D_3D_COUNT    250
>
> I think you want to leave 3D_COUNT alone... the point was to
> distinguish it from the CP_COUNT I think, but 3D_3D_COUNT seems a bit
> excessive :) Otherwise, this series is

Good catch, I need to remove one of the 3D. :-)

>
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>