[Mesa-dev] [PATCH 3/4] gallium: add caps to expose support for multi indirect draws

Marek Olšák maraeo at gmail.com
Fri Jan 1 03:52:19 PST 2016


Reviewed-by: Marek Olšák <marek.olsak at amd.com>

On Thu, Dec 31, 2015 at 8:55 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/gallium/docs/source/screen.rst               | 5 +++++
>  src/gallium/drivers/freedreno/freedreno_screen.c | 2 ++
>  src/gallium/drivers/i915/i915_screen.c           | 2 ++
>  src/gallium/drivers/ilo/ilo_screen.c             | 2 ++
>  src/gallium/drivers/llvmpipe/lp_screen.c         | 2 ++
>  src/gallium/drivers/nouveau/nv30/nv30_screen.c   | 2 ++
>  src/gallium/drivers/nouveau/nv50/nv50_screen.c   | 2 ++
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c   | 2 ++
>  src/gallium/drivers/r300/r300_screen.c           | 2 ++
>  src/gallium/drivers/r600/r600_pipe.c             | 2 ++
>  src/gallium/drivers/radeonsi/si_pipe.c           | 2 ++
>  src/gallium/drivers/softpipe/sp_screen.c         | 2 ++
>  src/gallium/drivers/svga/svga_screen.c           | 2 ++
>  src/gallium/drivers/vc4/vc4_screen.c             | 2 ++
>  src/gallium/drivers/virgl/virgl_screen.c         | 2 ++
>  src/gallium/include/pipe/p_defines.h             | 2 ++
>  16 files changed, 35 insertions(+)
>
> diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst
> index 41bd0f8..db70cc8 100644
> --- a/src/gallium/docs/source/screen.rst
> +++ b/src/gallium/docs/source/screen.rst
> @@ -213,6 +213,11 @@ The integer capabilities:
>  * ``PIPE_CAP_DRAW_INDIRECT``: Whether the driver supports taking draw arguments
>    { count, instance_count, start, index_bias } from a PIPE_BUFFER resource.
>    See pipe_draw_info.
> +* ``PIPE_CAP_MULTI_DRAW_INDIRECT``: Whether the driver supports
> +  pipe_draw_info::indirect_stride and ::indirect_count
> +* ``PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS``: Whether the driver supports
> +  taking the number of indirect draws from a separate parameter
> +  buffer, see pipe_draw_info::indirect_params.
>  * ``PIPE_CAP_TGSI_FS_FINE_DERIVATIVE``: Whether the fragment shader supports
>    the FINE versions of DDX/DDY.
>  * ``PIPE_CAP_VENDOR_ID``: The vendor ID of the underlying hardware. If it's
> diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
> index 4b6d6af..c684019 100644
> --- a/src/gallium/drivers/freedreno/freedreno_screen.c
> +++ b/src/gallium/drivers/freedreno/freedreno_screen.c
> @@ -226,6 +226,8 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>         case PIPE_CAP_TEXTURE_GATHER_OFFSETS:
>         case PIPE_CAP_TGSI_VS_WINDOW_SPACE_POSITION:
>         case PIPE_CAP_DRAW_INDIRECT:
> +       case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +       case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>         case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>         case PIPE_CAP_POLYGON_OFFSET_CLAMP:
>         case PIPE_CAP_MULTISAMPLE_Z_RESOLVE:
> diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c
> index 14bd8d7..d8cfcf0 100644
> --- a/src/gallium/drivers/i915/i915_screen.c
> +++ b/src/gallium/drivers/i915/i915_screen.c
> @@ -265,6 +265,8 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap)
>     case PIPE_CAP_TGSI_VS_LAYER_VIEWPORT:
>     case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>     case PIPE_CAP_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>     case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>     case PIPE_CAP_SAMPLER_VIEW_TARGET:
>        return 0;
> diff --git a/src/gallium/drivers/ilo/ilo_screen.c b/src/gallium/drivers/ilo/ilo_screen.c
> index ac29b56..4ca62a6 100644
> --- a/src/gallium/drivers/ilo/ilo_screen.c
> +++ b/src/gallium/drivers/ilo/ilo_screen.c
> @@ -463,6 +463,8 @@ ilo_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_TGSI_VS_WINDOW_SPACE_POSITION:
>     case PIPE_CAP_MAX_VERTEX_STREAMS:
>     case PIPE_CAP_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>     case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>     case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>     case PIPE_CAP_SAMPLER_VIEW_TARGET:
> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
> index 5352963..fcef3b6 100644
> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
> @@ -302,6 +302,8 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS:
>     case PIPE_CAP_CLEAR_TEXTURE:
>     case PIPE_CAP_DRAW_PARAMETERS:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>        return 0;
>     }
>     /* should only get here on unhandled cases */
> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> index 02303bb..dbe5b3c 100644
> --- a/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> +++ b/src/gallium/drivers/nouveau/nv30/nv30_screen.c
> @@ -157,6 +157,8 @@ nv30_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_USER_VERTEX_BUFFERS:
>     case PIPE_CAP_COMPUTE:
>     case PIPE_CAP_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>     case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>     case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>     case PIPE_CAP_SAMPLER_VIEW_TARGET:
> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_screen.c b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> index b3f2492..bcb8577 100644
> --- a/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> +++ b/src/gallium/drivers/nouveau/nv50/nv50_screen.c
> @@ -212,6 +212,8 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_TEXTURE_GATHER_OFFSETS:
>     case PIPE_CAP_TGSI_VS_WINDOW_SPACE_POSITION:
>     case PIPE_CAP_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>     case PIPE_CAP_VERTEXID_NOBASE:
>     case PIPE_CAP_MULTISAMPLE_Z_RESOLVE: /* potentially supported on some hw */
>     case PIPE_CAP_RESOURCE_FROM_USER_MEMORY:
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> index 19246f3..df8280d 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> @@ -217,6 +217,8 @@ nvc0_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>     case PIPE_CAP_VERTEXID_NOBASE:
>     case PIPE_CAP_RESOURCE_FROM_USER_MEMORY:
>     case PIPE_CAP_DEVICE_RESET_STATUS_QUERY:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>        return 0;
>
>     case PIPE_CAP_VENDOR_ID:
> diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c
> index e3f2505..7db184b 100644
> --- a/src/gallium/drivers/r300/r300_screen.c
> +++ b/src/gallium/drivers/r300/r300_screen.c
> @@ -183,6 +183,8 @@ static int r300_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>          case PIPE_CAP_SAMPLE_SHADING:
>          case PIPE_CAP_TEXTURE_GATHER_OFFSETS:
>          case PIPE_CAP_DRAW_INDIRECT:
> +        case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +        case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>          case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>          case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>          case PIPE_CAP_SAMPLER_VIEW_TARGET:
> diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c
> index 8208686..f17e8b4 100644
> --- a/src/gallium/drivers/r600/r600_pipe.c
> +++ b/src/gallium/drivers/r600/r600_pipe.c
> @@ -349,6 +349,8 @@ static int r600_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>         case PIPE_CAP_SHAREABLE_SHADERS:
>         case PIPE_CAP_CLEAR_TEXTURE:
>         case PIPE_CAP_DRAW_PARAMETERS:
> +       case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +       case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>                 return 0;
>
>         case PIPE_CAP_MAX_SHADER_PATCH_VARYINGS:
> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
> index fda5a1e..23bcd4d 100644
> --- a/src/gallium/drivers/radeonsi/si_pipe.c
> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
> @@ -341,6 +341,8 @@ static int si_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>         case PIPE_CAP_VERTEXID_NOBASE:
>         case PIPE_CAP_CLEAR_TEXTURE:
>         case PIPE_CAP_DRAW_PARAMETERS:
> +       case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +       case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>                 return 0;
>
>         case PIPE_CAP_MAX_SHADER_PATCH_VARYINGS:
> diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c
> index 7a35a2a..ab3b234 100644
> --- a/src/gallium/drivers/softpipe/sp_screen.c
> +++ b/src/gallium/drivers/softpipe/sp_screen.c
> @@ -252,6 +252,8 @@ softpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS:
>     case PIPE_CAP_CLEAR_TEXTURE:
>     case PIPE_CAP_DRAW_PARAMETERS:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>        return 0;
>     }
>     /* should only get here on unhandled cases */
> diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c
> index fe8e75e..d9baf5d 100644
> --- a/src/gallium/drivers/svga/svga_screen.c
> +++ b/src/gallium/drivers/svga/svga_screen.c
> @@ -342,6 +342,8 @@ svga_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_TEXTURE_GATHER_OFFSETS:
>     case PIPE_CAP_TGSI_VS_WINDOW_SPACE_POSITION:
>     case PIPE_CAP_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>     case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>     case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>     case PIPE_CAP_SAMPLER_VIEW_TARGET:
> diff --git a/src/gallium/drivers/vc4/vc4_screen.c b/src/gallium/drivers/vc4/vc4_screen.c
> index e845dfd..a5c69e9 100644
> --- a/src/gallium/drivers/vc4/vc4_screen.c
> +++ b/src/gallium/drivers/vc4/vc4_screen.c
> @@ -171,6 +171,8 @@ vc4_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>          case PIPE_CAP_MAX_TEXEL_OFFSET:
>          case PIPE_CAP_MAX_VERTEX_STREAMS:
>          case PIPE_CAP_DRAW_INDIRECT:
> +        case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +        case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>          case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>          case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>          case PIPE_CAP_SAMPLER_VIEW_TARGET:
> diff --git a/src/gallium/drivers/virgl/virgl_screen.c b/src/gallium/drivers/virgl/virgl_screen.c
> index 668f2e0..fa1a551 100644
> --- a/src/gallium/drivers/virgl/virgl_screen.c
> +++ b/src/gallium/drivers/virgl/virgl_screen.c
> @@ -201,6 +201,8 @@ virgl_get_param(struct pipe_screen *screen, enum pipe_cap param)
>     case PIPE_CAP_TGSI_VS_WINDOW_SPACE_POSITION:
>     case PIPE_CAP_MAX_VERTEX_STREAMS:
>     case PIPE_CAP_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT:
> +   case PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS:
>     case PIPE_CAP_TGSI_FS_FINE_DERIVATIVE:
>     case PIPE_CAP_CONDITIONAL_RENDER_INVERTED:
>     case PIPE_CAP_MAX_VERTEX_ATTRIB_STRIDE:
> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> index d4933e7..7eb3f8a 100644
> --- a/src/gallium/include/pipe/p_defines.h
> +++ b/src/gallium/include/pipe/p_defines.h
> @@ -636,6 +636,8 @@ enum pipe_cap
>     PIPE_CAP_COPY_BETWEEN_COMPRESSED_AND_PLAIN_FORMATS,
>     PIPE_CAP_CLEAR_TEXTURE,
>     PIPE_CAP_DRAW_PARAMETERS,
> +   PIPE_CAP_MULTI_DRAW_INDIRECT,
> +   PIPE_CAP_MULTI_DRAW_INDIRECT_PARAMS,
>  };
>
>  #define PIPE_QUIRK_TEXTURE_BORDER_COLOR_SWIZZLE_NV50 (1 << 0)
> --
> 2.4.10
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list