[Mesa-dev] [PATCH 2/6] radeonsi: pass si_context down into si_shader_binary_read
Nicolai Hähnle
nhaehnle at gmail.com
Fri Jan 1 08:04:46 PST 2016
On 31.12.2015 20:14, Marek Olšák wrote:
> On Thu, Dec 31, 2015 at 3:30 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>
>> This will allow us to send shader debug info via the context's debug callback.
>
> Could we please pass struct pipe_debug_callback to si_shader_create
> instead of si_context? This is defensive programming - the compilation
> shouldn't depend on any context state, so it shouldn't receive
> si_context.
Okay, that makes sense. I'll push modified 1-5 when I get back and just
drop patch #6.
Thanks!
Nicolai
>
> Thanks,
> Marek
>
More information about the mesa-dev
mailing list