[Mesa-dev] [PATCH 5/9] gallium/radeon: always add +DumpCode to the LLVM target machine for LLVM <= 3.5

[Marek Olšák]

On Sat, Jan 2, 2016 at 11:01 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> What's the reason for always having +DumpCode? Generating the assembly is
> some overhead that's usually unnecessary. Even if it's a small part of the
> profiles I've seen, it still seems like a natural thing to just skip. From
> what I can tell it should be dependent on any of the shader dumping flags +
> DBG_CHECK_VM being set. In any case, I suppose that would be for a separate
> commit.

Yeah, I agree that we shouldn't always generate the assembly string.

However, there is one case where we probably want to dump it always:
when a shader cache is used. We'll have only one chance to compile a
shader with a shader cache. If we decide not to generate the assembly,
we won't have it for all subsequent uses of the shader (even in other
processes).

Marek