[Mesa-dev] [PATCH 1/6] gallium: document PK2H/UP2H

Ilia Mirkin imirkin at alum.mit.edu
Sun Jan 3 12:32:31 PST 2016


On Sun, Jan 3, 2016 at 2:15 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Sun, Jan 3, 2016 at 2:08 PM, Roland Scheidegger <sroland at vmware.com> wrote:
>>>> For the series (with the first point addressed either way,though a tgsi
>>>> exec implementation which should be trivial wouldn't hurt neither)
>>>> Reviewed-by: Roland Scheidegger <sroland at vmware.com>
>>>
>>> Thanks! I'll do a patch for that shortly (tgsi_exec). Unfortunately I
>>> won't be able to enable the cap since it will still use gallivm by
>>> default for vertices. I have a gallivm implementation as well, but it
>>> hits asserts on LLVM 3.5. I'm pretty sure I tested it at one point or
>>> another, but it must have been on another box with a more recent LLVM.
>>
>> Ah right. f16 conversion is pretty annoying indeed, though I'd hope the
>> helpers for that should work. In any case, I only really suggested that
>> because I'd thought it would be trivial, so if it's not I don't consider
>> that important...
>
> I'll send it out as a separate series, including my (semi?) broken
> gallivm impl and leave it to you to fix it if you care, or ignore if
> you don't. (I already have it, so might as well...) I understand
> neither how LLVM works, nor how gallivm uses LLVM, which isn't a great
> combination :)

And of course the piglits expect out-of-bounds numbers to be
represented as infinities, instead of the clamped value, which is what
util_float_to_half does :(


More information about the mesa-dev mailing list