[Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

[Ilia Mirkin]

On Mon, Jan 4, 2016 at 11:14 AM, Rob Clark <robdclark at gmail.com> wrote:
> On Mon, Jan 4, 2016 at 11:03 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> On Mon, Jan 4, 2016 at 10:30 AM, Rob Clark <robdclark at gmail.com> wrote:
>>> On Sat, Jan 2, 2016 at 11:37 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>>> ---
>>>>  src/gallium/auxiliary/tgsi/tgsi_build.c            | 62 +++++++++--------
>>>>  src/gallium/auxiliary/tgsi/tgsi_dump.c             | 10 +--
>>>>  src/gallium/auxiliary/tgsi/tgsi_parse.c            |  4 +-
>>>>  src/gallium/auxiliary/tgsi/tgsi_parse.h            |  2 +-
>>>>  src/gallium/auxiliary/tgsi/tgsi_strings.c          |  4 +-
>>>>  src/gallium/auxiliary/tgsi/tgsi_text.c             | 10 +--
>>>>  src/gallium/auxiliary/tgsi/tgsi_ureg.c             | 77 ++++++++++++++++++++++
>>>>  src/gallium/auxiliary/tgsi/tgsi_ureg.h             |  7 ++
>>>>  src/gallium/drivers/ilo/shader/toy_tgsi.c          |  8 +--
>>>>  .../drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp  | 12 +++-
>>>>  src/gallium/drivers/svga/svga_tgsi_vgpu10.c        |  2 +
>>>>  src/gallium/include/pipe/p_shader_tokens.h         |  7 +-
>>>
>>> missing src/gallium/docs/source/tgsi.rst ?
>>
>> What sort of change were you hoping to see in there? FWIW I have a
>> later patch which updates the LOAD/etc ops to talk about buffer/image
>> things.
>
> I suspect at a minimum s/RESOURCE/IMAGE/g.  Although if more docs
> coming in later patch that is even better.

Yeah, I believe I update the relevant stuff. I do keep instances of
the word "resource" though, sometimes to refer to either an IMAGE or a
BUFFER (defined in the next patch). Ops like LOAD behave slightly
differently depending on the resource type they are given. I think of
both images and buffers as "resources". However there should be no
(uncommented) references to RESOURCE left after these patches.

Cheers,

  -ilia