[Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

[Ilia Mirkin]

On Mon, Jan 4, 2016 at 3:25 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Mon, Jan 4, 2016 at 3:13 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> On 01/03/2016 05:37 AM, Ilia Mirkin wrote:
>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>> diff --git a/src/gallium/auxiliary/tgsi/tgsi_strings.c
>>> b/src/gallium/auxiliary/tgsi/tgsi_strings.c
>>> index fd926b3..ae30399 100644
>>> --- a/src/gallium/auxiliary/tgsi/tgsi_strings.c
>>> +++ b/src/gallium/auxiliary/tgsi/tgsi_strings.c
>>> @@ -54,8 +54,8 @@ static const char *tgsi_file_names[] =
>>>      "IMM",
>>>      "PRED",
>>>      "SV",
>>> -   "RES",
>>> -   "SVIEW"
>>> +   "IMAGE",
>>> +   "SVIEW",
>>>   };
>>
>>
>> You forgot to update src/gallium/tests/trivial/compute.c, and so you did
>> break all of those compute tests. Please don't break them because they are
>> useful for people which work on compute. :-)
>
> Can I update it by deleting it? Like I was saying, all that stuff
> needs to be reworked... since compute.c doesn't *actually* work with
> anything, and actively conflicts with plans for OpenGL things, I see
> no problem with just invalidating the interfaces it was using. (This
> is also why I was discouraging people from trying to do TGSI with
> compute without considering these things first.)

After some IRC discussion with Samuel we agreed that I'll just note
that I'm breaking the sole user of the RESOURCE TGSI in the commit,
and the test can be updated when someone has time to think about how
clover should plug into the new GL-facing interfaces being developed.

  -ilia