[Mesa-dev] [PATCH] i965: Use rcp in brw_lower_texture_gradients rather than 1.0 / x.

Pohjolainen, Topi topi.pohjolainen at intel.com
Tue Jan 5 08:27:40 PST 2016


On Tue, Jan 05, 2016 at 05:33:09AM -0800, Kenneth Graunke wrote:
> That's what it's for.  Plus, we actually implement rcp.

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>

> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp b/src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp
> index d571ecd..c83b272 100644
> --- a/src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp
> @@ -279,7 +279,7 @@ lower_texture_grad_visitor::visit_leave(ir_texture *ir)
>  
>        /* 2. quotient rule */
>        ir_variable *recip = temp(mem_ctx, glsl_type::float_type, "recip");
> -      EMIT(assign(recip, div(new(mem_ctx) ir_constant(1.0f), swizzle_z(Q))));
> +      EMIT(assign(recip, expr(ir_unop_rcp, swizzle_z(Q))));
>  
>        ir_variable *dx = temp(mem_ctx, glsl_type::vec2_type, "dx");
>        ir_variable *dy = temp(mem_ctx, glsl_type::vec2_type, "dy");
> -- 
> 2.6.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list