[Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

[Marek Olšák]

On Tue, Jan 5, 2016 at 5:19 PM, Axel Davy <axel.davy at ens.fr> wrote:
> Hi Nicolas,
>
> I believe this patch doesn't fully solve the problem and could introduce
> some bugs.
>
> For example you change dri2_create_image_from_name pitch argument to stride,
> whereas this function is used as is to implement createImageFromName from
> __DRIimageExtensionRec,
> which takes a pitch. That said for this very function I'm not sure it is
> used correctly by the other parts of mesa,
> for example in dri2_create_image_mesa_drm_buffer it seems to pass a stride
> ...
>
> It is a good idea to clean the pitch/stride confusions that can occur in the
> code, but you should fix
> all occurences, not just some subset. I mean you'll have to change
> __DRIimageExtensionRec spec,
> adapt all users and implementers.

No, __DRIimageExtensionRec can't be changed. It's part of the stable
libGL->driver interface.

Marek