[Mesa-dev] [PATCH 1/8] tgsi: add ureg support for image decls

[Roland Scheidegger]

Am 04.01.2016 um 22:00 schrieb Samuel Pitoiset:
> 
> 
> On 01/04/2016 09:25 PM, Ilia Mirkin wrote:
>> On Mon, Jan 4, 2016 at 3:13 PM, Samuel Pitoiset
>> <samuel.pitoiset at gmail.com> wrote:
>>> On 01/03/2016 05:37 AM, Ilia Mirkin wrote:
>>>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>>> diff --git a/src/gallium/auxiliary/tgsi/tgsi_strings.c
>>>> b/src/gallium/auxiliary/tgsi/tgsi_strings.c
>>>> index fd926b3..ae30399 100644
>>>> --- a/src/gallium/auxiliary/tgsi/tgsi_strings.c
>>>> +++ b/src/gallium/auxiliary/tgsi/tgsi_strings.c
>>>> @@ -54,8 +54,8 @@ static const char *tgsi_file_names[] =
>>>>       "IMM",
>>>>       "PRED",
>>>>       "SV",
>>>> -   "RES",
>>>> -   "SVIEW"
>>>> +   "IMAGE",
>>>> +   "SVIEW",
>>>>    };
>>>
>>>
>>> You forgot to update src/gallium/tests/trivial/compute.c, and so you did
>>> break all of those compute tests. Please don't break them because
>>> they are
>>> useful for people which work on compute. :-)
>>
>> Can I update it by deleting it? Like I was saying, all that stuff
>> needs to be reworked... since compute.c doesn't *actually* work with
>> anything, and actively conflicts with plans for OpenGL things, I see
>> no problem with just invalidating the interfaces it was using. (This
>> is also why I was discouraging people from trying to do TGSI with
>> compute without considering these things first.)
> 
> We discussed about that on IRC and the plan is to update compute.c once
> the interface will be more suitable (when BUFFER/IMAGE will be
> implemented) because this RES thing is weird and need to be removed.
> 
FWIW the RES file name probably wasn't really intended to be used for
this in the first place. d3d10 has input resource declarations. These
are just your ordinary resource declarations for shaders to be used for
texturing / fetch (which of course GL doesn't have as it just has
samplers instead of samplers + resources). Albeit we used SVIEW for that
instead, I'm not entirely sure why actually, you can see in the svga
driver that it uses all this "resource" naming for converting sviews to
our protocol...

Roland