[Mesa-dev] [PATCH 1/5] mesa/bufferobj: make _mesa_delete_buffer_object externally accessible

Ian Romanick idr at freedesktop.org
Thu Jan 7 13:49:01 PST 2016


This patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I'm sending a comment on patch 3.  When this series lands, I think it
should also get tagged for stable.

Cc: "11.0 11.1" <mesa-stable at lists.freedesktop.org>

On 01/05/2016 06:53 PM, Nicolai Hähnle wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
> 
> gl_buffer_object has grown more complicated and requires cleanup. Using this
> function from drivers will be more future-proof.
> ---
>  src/mesa/main/bufferobj.c | 2 +-
>  src/mesa/main/bufferobj.h | 4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index 8a9f9b6..4a098ac 100644
> --- a/src/mesa/main/bufferobj.c
> +++ b/src/mesa/main/bufferobj.c
> @@ -447,7 +447,7 @@ _mesa_new_buffer_object(struct gl_context *ctx, GLuint name)
>   *
>   * Default callback for the \c dd_function_table::DeleteBuffer() hook.
>   */
> -static void
> +void
>  _mesa_delete_buffer_object(struct gl_context *ctx,
>                             struct gl_buffer_object *bufObj)
>  {
> diff --git a/src/mesa/main/bufferobj.h b/src/mesa/main/bufferobj.h
> index 3eac96d..a5bfe88 100644
> --- a/src/mesa/main/bufferobj.h
> +++ b/src/mesa/main/bufferobj.h
> @@ -109,6 +109,10 @@ _mesa_initialize_buffer_object(struct gl_context *ctx,
>                                 GLuint name);
>  
>  extern void
> +_mesa_delete_buffer_object(struct gl_context *ctx,
> +                           struct gl_buffer_object *bufObj);
> +
> +extern void
>  _mesa_reference_buffer_object_(struct gl_context *ctx,
>                                 struct gl_buffer_object **ptr,
>                                 struct gl_buffer_object *bufObj);
> 



More information about the mesa-dev mailing list