[Mesa-dev] [PATCH] configure.ac: always define __STDC_CONSTANT_MACROS

Ilia Mirkin imirkin at alum.mit.edu
Mon Jan 11 13:09:42 PST 2016


I'm not strictly opposed to passing this in, but... why not just fix
it by removing that imho weird macro and instead use ULL suffix on
literals?

On Mon, Jan 11, 2016 at 4:07 PM, Oded Gabbay <oded.gabbay at gmail.com> wrote:
> The ISO C99 standard (7.18.4) specifies that C++
> implementations should define UINT64_C only when
> __STDC_CONSTANT_MACROS is defined.
>
> ecause we now use UINT64_C in our cpp files (since commit
> 208bfc493debe0344d0b9cb93975981f14412628), we need to add this define.
>
> This also solves compilation errors with GCC 4.8.x on ppc64le machines.
>
> Signed-off-by: Oded Gabbay <oded.gabbay at gmail.com>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 9c3d1a3..8d19dab 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -245,7 +245,7 @@ _SAVE_LDFLAGS="$LDFLAGS"
>  _SAVE_CPPFLAGS="$CPPFLAGS"
>
>  dnl Compiler macros
> -DEFINES="-D__STDC_LIMIT_MACROS"
> +DEFINES="-D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS"
>  AC_SUBST([DEFINES])
>  case "$host_os" in
>  linux*|*-gnu*|gnu*)
> --
> 2.5.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list