[Mesa-dev] [PATCH] nvc0: remove useless goto in nvc0_launch_grid()

Ilia Mirkin imirkin at alum.mit.edu
Mon Jan 11 15:18:58 PST 2016


Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Mon, Jan 11, 2016 at 6:12 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Trivial.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c b/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
> index 6ce96ae..795c027 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
> @@ -433,8 +433,10 @@ nvc0_launch_grid(struct pipe_context *pipe,
>     int ret;
>
>     ret = !nvc0_compute_state_validate(nvc0);
> -   if (ret)
> -      goto out;
> +   if (ret) {
> +      NOUVEAU_ERR("Failed to launch grid !\n");
> +      return;
> +   }
>
>     nvc0_compute_upload_input(nvc0, input);
>
> @@ -491,8 +493,4 @@ nvc0_launch_grid(struct pipe_context *pipe,
>     }
>     memset(nvc0->state.uniform_buffer_bound, 0,
>            sizeof(nvc0->state.uniform_buffer_bound));
> -
> -out:
> -   if (ret)
> -      NOUVEAU_ERR("Failed to launch grid !\n");
>  }
> --
> 2.6.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list