[Mesa-dev] [PATCH] nvc0: do not force re-binding of compute constbufs on Fermi

[Ilia Mirkin]

On Mon, Jan 11, 2016 at 6:42 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Re-binding compute constant buffers after launching a grid have no effects
> because they are not currently validated and because dirty_cp is not updated
> accordingly. This might also prevent weird future behaviours when UBOs will
> be binded for compute.

will be *bound* for compute. (Past tense of "bind" is "bound". As is
the future subjunctive or whatever this is.)

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c b/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
> index 795c027..6702bf0 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
> @@ -486,7 +486,7 @@ nvc0_launch_grid(struct pipe_context *pipe,
>     /* rebind all the 3D constant buffers
>      * (looks like binding a CB on COMPUTE clobbers 3D state) */
>     nvc0->dirty |= NVC0_NEW_CONSTBUF;
> -   for (s = 0; s < 6; s++) {
> +   for (s = 0; s < 5; s++) {
>        for (i = 0; i < NVC0_MAX_PIPE_CONSTBUFS; i++)
>           if (nvc0->constbuf[s][i].u.buf)
>              nvc0->constbuf_dirty[s] |= 1 << i;
> --
> 2.6.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev