[Mesa-dev] [PATCH 18/28] glsl: validate linking of intrastage component qualifiers

[Anuj Phogat]

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri
<timothy.arceri at collabora.com> wrote:
> ---
>  src/glsl/linker.cpp | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
> index f709922..41ff057 100644
> --- a/src/glsl/linker.cpp
> +++ b/src/glsl/linker.cpp
> @@ -990,6 +990,13 @@ cross_validate_globals(struct gl_shader_program *prog,
>                      return;
>                }
>
> +              if (var->data.location_frac != existing->data.location_frac) {
> +                    linker_error(prog, "explicit components for %s "
> +                                 "`%s' have differing values\n",
> +                                 mode_string(var), var->name);
> +                    return;
> +              }
> +
>                existing->data.location = var->data.location;
>                existing->data.explicit_location = true;
>             }
> --
> 2.4.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>