[Mesa-dev] [PATCH 7/7] i965/vec4: Drop support for ATTR as an instruction destination.

[Kenneth Graunke]

On Thursday, January 14, 2016 10:26:37 AM PST Matt Turner wrote:
> On Wed, Jan 13, 2016 at 8:33 PM, Kenneth Graunke <kenneth at whitecape.org> 
wrote:
> > This is no longer necessary...and it doesn't make much sense to
> > have inputs as destinations.
> > 
> > Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> > ---
> 
> I don't think I realized they were ever destinations. I'm confused about how
> the
> 
>    switch (inst->dst.file) {
>    [...]
>    case ATTR:
> 
> was marked as unreachable() in dump_instructions(). Was that just broken?
> 
> Reviewed-by: Matt Turner <mattst88 at gmail.com>

Yes, there was a surprising amount of code that never handled this,
including dump_instructions().  It was just broken.  I had thought
this patch would delete more code.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20160114/13ef8727/attachment.sig>