[Mesa-dev] [PATCH 1/2] radeonsi: Print "LLVM emitted unknown config register" warning only once

[Nicolai Hähnle]

On 15.01.2016 05:30, Gustaw Smolarczyk wrote:
> Hi Michel.
>
> What will happen if there are 2 different uknown registers? With this
> patch, only the first one will be shown.

That doesn't really matter. The point is to give some indication of a 
possible cause of badness, i.e. a hint that one might want to try 
versions of LLVM and Mesa that are closer together.

The series is

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>


> Gustaw Smolarczyk
>
> 2016-01-15 10:23 GMT+01:00  <eocallaghan at alterapraxis.com>:
>> This series is,
>>
>> Reviewed-by: Edward O'Callaghan <eocallaghan at alterapraxis.com>
>>
>>
>> On 2016-01-15 14:23, Michel Dänzer wrote:
>>>
>>> From: Michel Dänzer <michel.daenzer at amd.com>
>>>
>>> Say "LLVM" instead of "Compiler" for clarity.
>>>
>>> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>>> ---
>>>   src/gallium/drivers/radeonsi/si_shader.c | 11 +++++++++--
>>>   1 file changed, 9 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/src/gallium/drivers/radeonsi/si_shader.c
>>> b/src/gallium/drivers/radeonsi/si_shader.c
>>> index cc9718e..3ab054c 100644
>>> --- a/src/gallium/drivers/radeonsi/si_shader.c
>>> +++ b/src/gallium/drivers/radeonsi/si_shader.c
>>> @@ -3735,8 +3735,15 @@ void si_shader_binary_read_config(struct
>>> radeon_shader_binary *binary,
>>>                                  G_00B860_WAVESIZE(value) * 256 * 4 * 1;
>>>                          break;
>>>                  default:
>>> -                       fprintf(stderr, "Warning: Compiler emitted unknown
>>> "
>>> -                               "config register: 0x%x\n", reg);
>>> +                       {
>>> +                               static bool printed;
>>> +
>>> +                               if (!printed) {
>>> +                                       fprintf(stderr, "Warning: LLVM
>>> emitted unknown "
>>> +                                               "config register: 0x%x\n",
>>> reg);
>>> +                                       printed = true;
>>> +                               }
>>> +                       }
>>>                          break;
>>>                  }
>>>          }
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>