[Mesa-dev] [PATCH 05/10] st/mesa: add support for SSBO binding and GLSL intrinsics

[Marek Olšák]

This looks good except glsl_to_tgsi, which I'm not familiar with.

Also, you use more than 80 characters per line where it can't be
justified that it improves readability.

Marek

On Mon, Jan 18, 2016 at 6:51 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/mesa/Makefile.sources                    |   1 +
>  src/mesa/state_tracker/st_atom.c             |   5 +
>  src/mesa/state_tracker/st_atom.h             |   5 +
>  src/mesa/state_tracker/st_atom_storagebuf.c  | 188 +++++++++++++++++++++++++++
>  src/mesa/state_tracker/st_cb_bufferobjects.c |   1 +
>  src/mesa/state_tracker/st_context.c          |   1 +
>  src/mesa/state_tracker/st_context.h          |   1 +
>  src/mesa/state_tracker/st_extensions.c       |  14 +-
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp   | 180 ++++++++++++++++++++++++-
>  9 files changed, 388 insertions(+), 8 deletions(-)
>  create mode 100644 src/mesa/state_tracker/st_atom_storagebuf.c