[Mesa-dev] [PATCH 2/9] gallium: Add PIPE_CAP_SURFACE_REINTERPRET_BLOCKS

[Ilia Mirkin]

On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
> index 69a55d4..92798fb 100644
> --- a/src/gallium/drivers/freedreno/freedreno_screen.c
> +++ b/src/gallium/drivers/freedreno/freedreno_screen.c
> @@ -249,6 +249,7 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>         case PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT:
>         case PIPE_CAP_INVALIDATE_BUFFER:
>         case PIPE_CAP_GENERATE_MIPMAP:
> +    case PIPE_CAP_SURFACE_REINTERPRET_BLOCKS:
>                 return 0;

Looks like there was a screwup here... you used 4 spaces instead of a
tab. The freedreno coding style, oddly, uses tabs set to a 4-space
tabstop (and has a .dir-locals.el to match).

[Following each driver's spacing style is one of the more annoying
bits of adding caps... my strategy is usually to just copy some
previous line and then double-check in "git diff" that everything
lines up.]

Oh, and contrary to my comment on patch 1, you've already stuck these
caps into the "unsupported" sections of nv30/nv50/nvc0, so all good.

  -ilia