[Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

Brian Paul brianp at vmware.com
Tue Jan 19 06:44:23 PST 2016


On 01/19/2016 07:37 AM, Ilia Mirkin wrote:
> On Tue, Jan 19, 2016 at 9:34 AM, Brian Paul <brianp at vmware.com> wrote:
>> I don't have any issue with simply adding PROGRAM_BUFFER to the enum type.
>> prog_src_register::File is a 4-bit field and we currently have 13 enum
>> values so we're safe there (not sure if that even matters).
>
> That's cutting it close... 13 = immed, 14 = buffer, 15 = image, and
> we're out of items... if you're OK with that, I'll revert this change
> and throw PROGRAM_IMMEDIATE and PROGRAM_BUFFER into the
> gl_register_file list.

Sure.  We can always bump up the bitfield size if needed.

-Brian




More information about the mesa-dev mailing list