[Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

Francisco Jerez currojerez at riseup.net
Tue Jan 19 19:23:01 PST 2016


Timothy Arceri <timothy.arceri at collabora.com> writes:

> Fixes piglit regression after fixes to duplicate layout rules.
>
> Previously catching multiple layouts was relying on the code
> meant to catch duplicates within a single layout(...), this
> change triggers the rules for multiple layouts.
>
> Cc: Mark Janes <mark.a.janes at intel.com>
> ---
>  src/glsl/ast_type.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/glsl/ast_type.cpp b/src/glsl/ast_type.cpp
> index cf494d9..e0e3311 100644
> --- a/src/glsl/ast_type.cpp
> +++ b/src/glsl/ast_type.cpp
> @@ -74,6 +74,7 @@ ast_type_qualifier::has_layout() const
>            || this->flags.q.row_major
>            || this->flags.q.packed
>            || this->flags.q.explicit_location
> +          || this->flags.q.explicit_image_format
>            || this->flags.q.explicit_index
>            || this->flags.q.explicit_binding
>            || this->flags.q.explicit_offset

Looks reasonable to me,
Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> -- 
> 2.4.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20160119/46d1c6ce/attachment.sig>


More information about the mesa-dev mailing list