[Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

[Ilia Mirkin]

On Tue, Jan 19, 2016 at 6:35 AM, Tapani Pälli <tapani.palli at intel.com> wrote:
> On 01/19/2016 01:14 PM, Ilia Mirkin wrote:
>>
>> The data structure is a (memory) heap... there appears to be one in
>> mesa/main/mm.h. There's also one in nouveau_heap.h which is quite
>> simple and totally unreliant on nouveau, just happens to be there. How
>> hard would it be to integrate something like that?
>>
>> The trouble with adding slow things is that you forget about them, and
>> they're not _that_ slow, but this stuff adds up.
>
>
> The solution I had in mind is to build a list of empty slots when allocating
> remaptable or while finding slots (keep pushing unused empty slots to list)
> ... but if possible I would prefer optimization later. First of all, this is
> quite exotic path to hit with a real program (last words ... yes yes).
> Secondly, and more importantly, we can apply for certification sooner, there
> are very few failures left.

I see you pushed this patch without concluding this discussion.
Certification may be something that you (personally, as a company,
whatever) are striving for, but that doesn't mean that you get to
ignore reviewer feedback.

Perhaps in the end you're actually right, I don't know, but we
certainly didn't agree on anything. I'm inclined to push out a revert
while this is being sorted out.

  -ilia