[Mesa-dev] [PATCH v2 1/4] mesa: add GREMEDY_string_marker

[Ian Romanick]

On 01/20/2016 12:36 PM, Ian Romanick wrote:
> On 01/20/2016 11:32 AM, Rob Clark wrote:
>> diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c
>> index 9e66109..fc3c6d0 100644
>> --- a/src/mesa/main/errors.c
>> +++ b/src/mesa/main/errors.c
>> @@ -1276,6 +1276,19 @@ _mesa_free_errors_data(struct gl_context *ctx)
>>     mtx_destroy(&ctx->DebugMutex);
>>  }
>>  
>> +void GLAPIENTRY
>> +_mesa_StringMarkerGREMEDY(GLsizei len, const GLvoid * string)
>                                                         ^ spurious space
> 
>> +{
>> +   GET_CURRENT_CONTEXT(ctx);
>> +   if (ctx->Driver.EmitStringMarker) {
> 
> I think this would be better as a check for the extension enable.  If
> the extension is enabled, it should be safe to assume the driver
> provides dd:EmitStringMarker.

I should add that with those things fixed, this patch is:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>