[Mesa-dev] [PATCH] glsl: always compute proper varying type, irrespective of varying packing

[Ilia Mirkin]

On Thu, Jan 21, 2016 at 7:39 AM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Thu, Jan 21, 2016 at 7:37 AM, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
>>
>>
>> On 21 January 2016 11:30:21 pm AEDT, Timothy Arceri <t_arceri at yahoo.com.au> wrote:
>>>
>>>
>>>On 21 January 2016 11:17:06 pm AEDT, Ilia Mirkin <imirkin at alum.mit.edu>
>>>wrote:
>>>>Normally there's a producer and consumer, and the producer var gets
>>>>picked. In both the vertex->gs and tes->gs cases, that's the
>>>un-arrayed
>>>>version.
>>>>
>>>>In the SSO case, however, there is no producer. So we picked the
>>>>arrayed
>>>>GS variable, and as a result, used more slots than we should. More
>>>>critically, these slots would also no longer line up with the
>>>>producer's
>>>>calculation. To fix this, we need to fix up the type of the variable
>>>>based on stage no matter what.
>>>>
>>>>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93650
>>>>Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>>>
>>>Makes sense.
>>>
>>>Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>
>>>
>>>
>>
>> Are you planning on sending a piglit test for this too?
>
> Yeah, I think so... later today. Seems like it should be pretty easy
> to trigger, esp now that shader_runner can do SSO.
>
>   -ilia

Piglit sent, and verified that it's broken before this patch, and this
patch fixes it.

Cheers,

  -ilia