[Mesa-dev] [PATCH 0/6] Move nir/glsl to src/compiler, take 2

Jose Fonseca jfonseca at vmware.com
Sat Jan 23 13:52:50 PST 2016


On 22/01/16 16:43, Emil Velikov wrote:
> On 19 January 2016 at 22:36, Matt Turner <mattst88 at gmail.com> wrote:
>> On Mon, Jan 18, 2016 at 4:02 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> Hi all,
>>>
>>> Here is another attempt at splitting up nir, glsl and the rest.
>>>
>>> The gist is that we have three independent static libraries - compiler,
>>> nir and glsl. Thus we don't need to pull nir if working with glsl and
>>> vice versa.
>>>
>>> For compilation purposes the three (not to mention mesa ir) _are_
>>> entwined, yet we can only link against the ones we want.
>>>
>>> Changes since last time - restored the parallel build for glsl/nir
>>>
>>> The lot can be found in branch nir-glsl-move-v2 at
>>> https://github.com/evelikov/Mesa/commits/nir-glsl-move
>>>
>>> All builds have been tested, although do give it a go on your
>>> config/setup.
>>
>> I checked out your branch and tested it. Everything looks fine here.
>> Thanks Emil!
>>
>> Acked-by: Matt Turner <mattst88 at gmail.com>
>
> Thanks Matt.
>
> Jose, Brian can you give the series a quick look/test ? It build
> passed on AppVeyour (thanks for upstreaming the config :-) although
> one might want to give it a second on your end as well.
>
> I'd love to get this in the next couple of days to avoid rebase chaos.
>
> Cheers
> Emil
>

Hi Emil,

The SCons changes look good to me AFAICS.

Thanks for run it through on AppVeyor.

In the unlikely event there's an issue we can deal with it then.

Series is

Acked-by: Jose Fonseca <jfonseca at vmware.com>


More information about the mesa-dev mailing list