[Mesa-dev] [PATCH 2/2] winsys/amdgpu: Process RADEON_FLAG_* independently from RADEON_DOMAIN_*

[Alex Deucher]

On Tue, Jan 26, 2016 at 2:40 AM, Michel Dänzer <michel at daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
>
> In particular, AMDGPU_GEM_CREATE_CPU_GTT_USWC can affect even BOs created
> in VRAM if they get evicted to GTT. In general there's no need to
> restrict any of the flags to any particular domains.
>
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>

For the series:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> index 1e997d9..59a801b 100644
> --- a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c
> @@ -288,18 +288,17 @@ static struct amdgpu_winsys_bo *amdgpu_create_bo(struct amdgpu_winsys *ws,
>     request.alloc_size = size;
>     request.phys_alignment = alignment;
>
> -   if (initial_domain & RADEON_DOMAIN_VRAM) {
> +   if (initial_domain & RADEON_DOMAIN_VRAM)
>        request.preferred_heap |= AMDGPU_GEM_DOMAIN_VRAM;
> -      if (flags & RADEON_FLAG_CPU_ACCESS)
> -         request.flags |= AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED;
> -      if (flags & RADEON_FLAG_NO_CPU_ACCESS)
> -         request.flags |= AMDGPU_GEM_CREATE_NO_CPU_ACCESS;
> -   }
> -   if (initial_domain & RADEON_DOMAIN_GTT) {
> +   if (initial_domain & RADEON_DOMAIN_GTT)
>        request.preferred_heap |= AMDGPU_GEM_DOMAIN_GTT;
> -      if (flags & RADEON_FLAG_GTT_WC)
> -         request.flags |= AMDGPU_GEM_CREATE_CPU_GTT_USWC;
> -   }
> +
> +   if (flags & RADEON_FLAG_CPU_ACCESS)
> +      request.flags |= AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED;
> +   if (flags & RADEON_FLAG_NO_CPU_ACCESS)
> +      request.flags |= AMDGPU_GEM_CREATE_NO_CPU_ACCESS;
> +   if (flags & RADEON_FLAG_GTT_WC)
> +      request.flags |= AMDGPU_GEM_CREATE_CPU_GTT_USWC;
>
>     r = amdgpu_bo_alloc(ws->dev, &request, &buf_handle);
>     if (r) {
> --
> 2.7.0.rc3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev