[Mesa-dev] [PATCH 0/7] st/mesa: add shader image support

Dave Airlie airlied at gmail.com
Sat Jan 30 23:40:10 PST 2016


On 31 January 2016 at 11:55, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Please note that there is no complete nvc0 implementation backing this
> (unlike the SSBO case), so I have not done more complete dEQP tests,
> and a number of piglit tests fail.
>
> Furthermore, there's the RGBA vs BGRA format issue that needs to be
> resolved somehow. However I feel confident that this code is a good
> start, and works as advertised. In all of the image failures I've
> looked at, the TGSI always appeared correct.
>
> Please have a look and let me know if this interface seems workable,
> and what additional changes need to be done for this to be acceptable
> in mesa.

Looks workable for me, as in I got the basics running on r600 on top of this.

Reviewed-by: Dave Airlie <airlied at redhat.com> for the whole series, if you
address my comment on patch 6.

Dave.


More information about the mesa-dev mailing list