[Mesa-dev] [PATCH 2/6] Android: fix x86 gallium builds

[Emil Velikov]

On 29 January 2016 at 20:52, Rob Herring <robh at kernel.org> wrote:
> Builds with gallium enabled fail on x86 with linker error:
>
> external/mesa3d/src/mesa/vbo/vbo_exec_array.c:127: error: undefined reference to '_mesa_uint_array_min_max'
>
> Fix this by adding the missing file sse_minmax.c.
>
> Signed-off-by: Rob Herring <robh at kernel.org>
> ---
>  src/mesa/Android.libmesa_st_mesa.mk | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/mesa/Android.libmesa_st_mesa.mk b/src/mesa/Android.libmesa_st_mesa.mk
> index ee8887b..e86d118 100644
> --- a/src/mesa/Android.libmesa_st_mesa.mk
> +++ b/src/mesa/Android.libmesa_st_mesa.mk
> @@ -47,6 +47,8 @@ endif # x86
>  endif # MESA_ENABLE_ASM
>
>  ifeq ($(ARCH_X86_HAVE_SSE4_1),true)
> +LOCAL_SRC_FILES += \
> +       main/sse_minmax.c
>  LOCAL_CFLAGS := \
>         -DUSE_SSE41
>  endif

Can we please get the sse specific files into Makefile.sources, and a
single static lib. This way it can be reused by both classic dri
drivers and gallium ones.

-Emil