[Mesa-dev] [PATCH 3/6] Android: Fix building secondary arch in mixed 32/64-bit builds

[Emil Velikov]

On 29 January 2016 at 20:52, Rob Herring <robh at kernel.org> wrote:
> At least in Android M, using LOCAL_CC does not work for secondary arch
> when doing dual arch builds. Use LOCAL_CLFAGS and LOCAL_CONLYFLAGS
> instead.
>
Not really Android M specific afaict. You can get issues even with
Android 4.{3,4} as long as you're using clang/llvm. Android 4.4
onwards introduced LOCAL_CONLYFLAGS and imho it's unreasonable to
expect that mesa supports older Androids. Thus this change will be
safe. Can you please add something alike my that two sentences to the
commit message ?

> Cc: Emil Velikov <emil.l.velikov at gmail.com>
> Cc: Chih-Wei Huang <cwhuang at android-x86.org>
> Signed-off-by: Rob Herring <robh at kernel.org>
> ---
>  Android.common.mk | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/Android.common.mk b/Android.common.mk
> index 948561c..c882209 100644
> --- a/Android.common.mk
> +++ b/Android.common.mk
> @@ -22,12 +22,8 @@
>  # DEALINGS IN THE SOFTWARE.
>
>  # use c99 compiler by default
Please move this comment where it's applicable.

-Emil