[Mesa-dev] [PATCH 5/6] Android: disable unused-parameter warning

[Rob Herring]

On Sun, Jan 31, 2016 at 4:23 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 29 January 2016 at 20:52, Rob Herring <robh at kernel.org> wrote:
>> Android builds with -Wunused-parameter enabled which results in spewing
>> lots of warnings. Disable it so more meaningful warnings are more visible.
>>
> Would be great if one day we resolve them and even toggle -Wextra.
> Although I might be alone thinking about that one :-)

The correct setting is like trying to define the correct tab size. :)

I find this one in particular useless and the fix is not exactly elegant.

> That aside how many warning are we talking about ? I don't recall
> anything major - perhaps because Ian is good at fixing those every so
> often.

Here's a count:

      4 [-Wcpp]
     44 [-Wformat=]
      2 [-Wignored-qualifiers]
    110 [-Wmaybe-uninitialized]
      4 [-Wmissing-braces]
   1872 [-Wmissing-field-initializers]
    108 [-Woverride-init]
    238 [-Wpointer-arith]
      8 [-Wsign-promo]
      2 [-Wstrict-overflow]
      8 [-Wswitch]
     24 [-Wtype-limits]
      3 [-Wunused-parameter]


>> Signed-off-by: Rob Herring <robh at kernel.org>
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks.

Rob