[Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode

Emil Velikov emil.l.velikov at gmail.com
Fri Jul 1 11:25:15 UTC 2016

Hi Boyuan,

I believe Christian already mentioned this - here (and other patches
really) you want to mention "why we want this". Something like "VAAPI
does not allow for XX and YY. And requires the driver to explicitly
manage/provide ZZ" will be more than enough imho.

In general I would suggest beefing up your commit messages - it's not
that every single commit has to have one, but from your existing 25+
patches (with this series) there's a total of ~5 lines worth. Do take
a look at [1] [2] for more info.


[1] http://who-t.blogspot.co.uk/2009/12/on-commit-messages.html
[2] http://chris.beams.io/posts/git-commit/

More information about the mesa-dev mailing list