[Mesa-dev] [Mesa-stable] [PATCH] radeon uvd add uvd fw version for amdgpu

Emil Velikov emil.l.velikov at gmail.com
Wed Jul 6 15:44:26 UTC 2016


On 6 July 2016 at 16:09, Jiang, Sonny <Sonny.Jiang at amd.com> wrote:
> Hi Emil,
>
>
> Are you Okay with these?
>
It'll do for now.

General suggestion - do not try to justifying the patch on the grounds
that it fixes a bug. Mention what was wrong and/or why it was resolved
in a particular way.

A style example/suggestion, which I believe your colleagues will be
quite pleased to see.

"[PATCH 2/2] radeon: sepArate uvd context buffer from DPB

Older Polaris FW does not handle XXX leading to bug in YYY. Newer one
resolves that by exposing/requiring the user to separate uvd context
buffer from DPB, and provide the AAA data via BBB."

Thanks
Emil
P.S. HTML emails and attached patches is a bad idea for mesa-dev@ (and
many other MLs).


More information about the mesa-dev mailing list