[Mesa-dev] [PATCH] egl: Fix the bad surface attributes combination checking for pbuffers. (v2)

Chad Versace chad.versace at intel.com
Thu Jul 7 01:12:04 UTC 2016

On Mon 20 Jun 2016, Guillaume Charifi wrote:
> Fixes a regression induced by commit a0674ce5c41903ccd161e89abb149621bfbc40d2:
> When EGL_TEXTURE_FORMAT and EGL_TEXTURE_TARGET were both specified (and
> both != EGL_NO_TEXTURE), an error was instantly triggered, before the
> other one had even a chance to be checked, which is obviously not the
> intended behaviour.
> v2: Full commit hash, remove useless variables.
> Signed-off-by: Guillaume Charifi <guillaume.charifi at sfr.fr>
> Reviewed-by: Frank Binns <frank.binns at imgtec.com>
> ---
>  src/egl/main/eglsurface.c | 36 +++++++++++++++---------------------
>  1 file changed, 15 insertions(+), 21 deletions(-)

This patch looks good to me. And I checked that it didn't regress

But I want to run the patch through Intel's Jenkins before giving my
reviewed-and-tested-by. The Jenkins run should finish before morning
(I'm US West Coast).

More information about the mesa-dev mailing list