[Mesa-dev] [PATCH 04/47] clover/llvm: Collect #ifdef mess into a separate file.

[Jan Vesely]

On Tue, 2016-07-12 at 21:19 +0200, Vedran Miletić wrote:
> 09.07.2016 u 00:10, Jan Vesely je napisao/la:
> > we still get 'macro redefined' complains from the compiler. and if
> > anyone adds ifdef DEBUG code in the future it will cause unexpected
> > behaviour.
> > this goes for every file that includes llvm headers. it'd be nicer
> > to
> > get mesa (and llvm) to stop using generic macro names, but I don't
> > think that's on anybody's todo list.
> > it was just a suggestion, feel free to ignore it.
> > 
> > Jan
> 
> I love cleaning stuff like that and can provide a patch changing
> DEBUG 
> to e.g. MESA_DEBUG, if that would solve the problem on Mesa's side.

I think it'll definitely help, and I think most ppl would be happy to
get rid of the conflict, but I don't speak for everyone who uses it.

Jan

> 
> Regards,
> Vedran
> 
-- 

Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160712/0a4f5eae/attachment.sig>