[Mesa-dev] [Mesa-stable] [PATCH] Revert "gallium: Force blend color to 16-byte alignment"

[Chuck Atkins]

Acked-by: Chuck Atkins <chuck.atkins at kitware.com>

- Chuck

On Wed, Jul 13, 2016 at 11:39 AM, Tim Rowley <timothy.o.rowley at intel.com>
wrote:

> This reverts commit d8d6091a846ac2a40a011d512d6d57f6c8442e6a.
>
> Cc: <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Tim Rowley <timothy.o.rowley at intel.com>
> ---
>  src/gallium/include/pipe/p_state.h | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/src/gallium/include/pipe/p_state.h
> b/src/gallium/include/pipe/p_state.h
> index a73a771..a3ae870 100644
> --- a/src/gallium/include/pipe/p_state.h
> +++ b/src/gallium/include/pipe/p_state.h
> @@ -326,17 +326,7 @@ struct pipe_blend_state
>
>  struct pipe_blend_color
>  {
> -   /**
> -    * Making the color array explicitly 16-byte aligned provides a hint to
> -    * compilers to make more efficient auto-vectorization optimizations.
> -    * The actual performance gains from vectorizing the blend color array
> are
> -    * fairly minimal, if any, but the alignment is necessary to work
> around
> -    * buggy vectorization in some compilers which fail to generate the
> correct
> -    * unaligned accessors resulting in a segfault.  Specifically several
> -    * versions of the Intel compiler are known to be affected but it's
> likely
> -    * others are as well.
> -    */
> -   PIPE_ALIGN_VAR(16) float color[4];
> +   float color[4];
>  };
>
>
> --
> 1.9.1
>
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160713/f05533a3/attachment.html>