[Mesa-dev] [PATCH] vl/dri3: fix a memory leak from front buffer
leo.liu at amd.com
Thu Jul 14 15:02:26 UTC 2016
Inspired by fix for mem leak of vdpau interop, resource_from_handle
set texture reference count, that need to be decreased and released,
recall there is a similar case for DRI3, that is with VA-API glx
extension, there is temporary TFP(texture from pixmap), we target it
through dma-buf. leak happens when without count down the reference.
Checked and found with mpv vo=opengl case, there only one static TFP,
the leak happens once, but for totem player using gstreamer VA-API glx,
the dynamic TFP for each frame, so leak quite a bit.
This fixes mem leak for mpv and totem.
Signed-off-by: Leo Liu <leo.liu at amd.com>
Cc: "12.0" <mesa-stable at lists.freedesktop.org>
src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
index f7f572e..493e645 100644
@@ -89,6 +89,7 @@ dri3_free_front_buffer(struct vl_dri3_screen *scrn,
+ pipe_resource_reference(&buffer->texture, NULL);
More information about the mesa-dev