[Mesa-dev] [PATCH] vl/dri3: fix a memory leak from front buffer
deathsimple at vodafone.de
Thu Jul 21 08:55:55 UTC 2016
Am 14.07.2016 um 17:02 schrieb Leo Liu:
> Inspired by fix for mem leak of vdpau interop, resource_from_handle
> set texture reference count, that need to be decreased and released,
> recall there is a similar case for DRI3, that is with VA-API glx
> extension, there is temporary TFP(texture from pixmap), we target it
> through dma-buf. leak happens when without count down the reference.
> Checked and found with mpv vo=opengl case, there only one static TFP,
> the leak happens once, but for totem player using gstreamer VA-API glx,
> the dynamic TFP for each frame, so leak quite a bit.
> This fixes mem leak for mpv and totem.
> Signed-off-by: Leo Liu <leo.liu at amd.com>
> Cc: "12.0" <mesa-stable at lists.freedesktop.org>
Looks like I never replied on this :( I simply have to much on my todo list.
Patch is Reviewed-by: Christian König <christian.koenig at amd.com> if you
haven't already pushed it.
> src/gallium/auxiliary/vl/vl_winsys_dri3.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/src/gallium/auxiliary/vl/vl_winsys_dri3.c b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> index f7f572e..493e645 100644
> --- a/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> +++ b/src/gallium/auxiliary/vl/vl_winsys_dri3.c
> @@ -89,6 +89,7 @@ dri3_free_front_buffer(struct vl_dri3_screen *scrn,
> xcb_sync_destroy_fence(scrn->conn, buffer->sync_fence);
> + pipe_resource_reference(&buffer->texture, NULL);
More information about the mesa-dev