[Mesa-dev] [PATCH v4 10/34] i965/miptree: Add a helper for getting an isl_surf from a miptree

[Chad Versace]

On Thu 14 Jul 2016, Jason Ekstrand wrote:
> On Thu, Jul 14, 2016 at 11:56 AM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> 
> >
> >
> > On Thu, Jul 14, 2016 at 11:42 AM, Chad Versace <chad.versace at intel.com>
> > wrote:
> >
> >> On Wed 13 Jul 2016, Jason Ekstrand wrote:
> >> > Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> >> > ---
> >> >  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 175
> >> +++++++++++++++++++++++++-
> >> >  src/mesa/drivers/dri/i965/intel_mipmap_tree.h |   6 +
> >> >  2 files changed, 179 insertions(+), 2 deletions(-)


> >> > +   if (mt->num_samples > 1) {
> >> > +      switch (mt->msaa_layout) {
> >> > +      case INTEL_MSAA_LAYOUT_NONE:
> >> > +         surf->msaa_layout = ISL_MSAA_LAYOUT_NONE;
> >> > +         break;
> >>
> >> How is this case possible? ISL_MSAA_LAYOUT_NONE && num_samples > 1?
> >>
> >
> > I don't think it is.  I can delete it and run through Jenkins if you'd
> > like.
> >
> 
> I ran it through jenkins with out this and everything is ok.  I'll go ahead
> and delete it.

Sounds good. This patch is
Reviewed-by: Chad Versace <chad.versace at intel.com>