[Mesa-dev] [Mesa-stable] [PATCH] mapi: Massage code to allow clang to compile.
emil.l.velikov at gmail.com
Tue Jul 19 11:41:37 UTC 2016
On 18 July 2016 at 21:54, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Jul 11, 2016 at 10:49 AM, Matt Turner <mattst88 at gmail.com> wrote:
>> According to https://llvm.org/bugs/show_bug.cgi?id=19778#c3 this code
>> was violating the spec, resulting in it failing to compile.
>> Cc: mesa-stable at lists.freedesktop.org
>> Co-authored-by: Tomasz Paweł Gajc <tpgxyz at gmail.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89599
>> I've tried for months to reproduce this, and I've still never been
>> able to on 64-bit builds. I can reproduce it on 32-bit however.
>> On MSVC, this patch will have the effect of changing the variables
>> from static to extern. I do not know if this will adversely affect
>> anything, so this patch would benefit from MSVC testing.
As mentioned before I'm not sure if C11 text should be applicable,
considering we're explicitly using c99/gnu99. That said it doesn't
make things explode afaics so let's merge it.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
The Windows build and tests to pass on AppVeyor  but the patch
could use some real world testing. Brian, Jose ?
More information about the mesa-dev