[Mesa-dev] [Mesa-stable] [PATCH] mapi: Massage code to allow clang to compile.

[Jose Fonseca]

AFAICS, this code is only used when USE_X86_ASM/USE_X86_64_ASM.  These are never defined on Windows (we never use the assembly files on Windows, regardless which compiler is used), therefore there should be no impact to MSVC or Windows builds.


Acked-by: Jose Fonseca <jfonseca at vmware.com>


Jose

PS: Thanks for CC'ing me.  Please feel free to do so whenever feedback concerning MSVC/Windows build is sought.

________________________________
From: Emil Velikov <emil.l.velikov at gmail.com>
Sent: Tuesday, July 19, 2016 12:41
To: Matt Turner; Brian Paul; Jose Fonseca
Cc: mesa-dev at lists.freedesktop.org; 9.2
Subject: Re: [Mesa-stable] [PATCH] mapi: Massage code to allow clang to compile.

On 18 July 2016 at 21:54, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Jul 11, 2016 at 10:49 AM, Matt Turner <mattst88 at gmail.com> wrote:
>> According to https://llvm.org/bugs/show_bug.cgi?id=19778#c3 this code
>> was violating the spec, resulting in it failing to compile.
>>
>> Cc: mesa-stable at lists.freedesktop.org
>> Co-authored-by: Tomasz Pawel Gajc <tpgxyz at gmail.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89599
>> ---
>> I've tried for months to reproduce this, and I've still never been
>> able to on 64-bit builds. I can reproduce it on 32-bit however.
>>
>> On MSVC, this patch will have the effect of changing the variables
>> from static to extern. I do not know if this will adversely affect
>> anything, so this patch would benefit from MSVC testing.
>
> Ping...
As mentioned before I'm not sure if C11 text should be applicable,
considering we're explicitly using c99/gnu99. That said it doesn't
make things explode afaics so let's merge it.

Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

The Windows build and tests to pass on AppVeyor [1] but the patch
could use some real world testing. Brian, Jose ?

Thanks
Emil

[1] https://ci.appveyor.com/project/evelikov/mesa-4up2g
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160719/34243e41/attachment-0001.html>