[Mesa-dev] [PATCH 1/2] clover: Add missing include

Ilia Mirkin imirkin at alum.mit.edu
Tue Jul 19 16:49:53 UTC 2016


On Tue, Jul 19, 2016 at 11:13 AM, Tom Stellard <thomas.stellard at amd.com> wrote:
> There was a patch committed to clang to remove unnecessary includes from
> header files, so we now need to explicitly include
> clang/Lex/PreprocessorOptions.h
> ---
>  src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> index 4b7de26..437d75e 100644
> --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> @@ -39,6 +39,8 @@
>  #include <llvm-c/Target.h>
>
>  #include <clang/CodeGen/CodeGenAction.h>
> +#include "clang/Lex/PreprocessorOptions.h"

Any reason that the rest of the includes use < > while this one uses "
"? I believe the style decides whether system paths are used first or
not. Or something along those lines...

> +
>  #include <clang/Frontend/TextDiagnosticBuffer.h>
>  #include <clang/Frontend/TextDiagnosticPrinter.h>
>  #include <clang/Basic/TargetInfo.h>
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list