[Mesa-dev] [PATCH 1/2] clover: Add missing include

[Jan Vesely]

On Tue, 2016-07-19 at 12:49 -0400, Ilia Mirkin wrote:
> On Tue, Jul 19, 2016 at 11:13 AM, Tom Stellard <thomas.stellard at amd.c
> om> wrote:
> > 
> > There was a patch committed to clang to remove unnecessary includes
> > from
> > header files, so we now need to explicitly include
> > clang/Lex/PreprocessorOptions.h

maybe mention that the clang changeset is r275822.

> > ---
> >  src/gallium/state_trackers/clover/llvm/invocation.cpp | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > index 4b7de26..437d75e 100644
> > --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp
> > @@ -39,6 +39,8 @@
> >  #include <llvm-c/Target.h>
> > 
> >  #include <clang/CodeGen/CodeGenAction.h>
> > +#include "clang/Lex/PreprocessorOptions.h"
> 
> Any reason that the rest of the includes use < > while this one uses
> "
> "? I believe the style decides whether system paths are used first or
> not. Or something along those lines...

I believe we use llvm-config to get include dirs and put them on
commandline, so both should work. For consistency sake <> is better.
Also it'd be nice to maintain alphabetic order (I understand that
TargetInfo.h breaks it now).

Jan

> 
> > 
> > +
> >  #include <clang/Frontend/TextDiagnosticBuffer.h>
> >  #include <clang/Frontend/TextDiagnosticPrinter.h>
> >  #include <clang/Basic/TargetInfo.h>
> > --
> > 2.7.4
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160719/44af5d9c/attachment.sig>