[Mesa-dev] [PATCH 1/2] clover: Add missing include

[Michel Dänzer]

On 20.07.2016 04:15, Jan Vesely wrote:
> On Tue, 2016-07-19 at 12:49 -0400, Ilia Mirkin wrote:
>> On Tue, Jul 19, 2016 at 11:13 AM, Tom Stellard <thomas.stellard at amd.c
>> om> wrote:
>>>
>>> diff --git a/src/gallium/state_trackers/clover/llvm/invocation.cpp
>>> b/src/gallium/state_trackers/clover/llvm/invocation.cpp
>>> index 4b7de26..437d75e 100644
>>> --- a/src/gallium/state_trackers/clover/llvm/invocation.cpp
>>> +++ b/src/gallium/state_trackers/clover/llvm/invocation.cpp
>>> @@ -39,6 +39,8 @@
>>>  #include <llvm-c/Target.h>
>>>
>>>  #include <clang/CodeGen/CodeGenAction.h>
>>> +#include "clang/Lex/PreprocessorOptions.h"
>>
>> Any reason that the rest of the includes use < > while this one uses
>> "
>> "? I believe the style decides whether system paths are used first or
>> not. Or something along those lines...
> 
> I believe we use llvm-config to get include dirs and put them on
> commandline, so both should work. For consistency sake <> is better.

Indeed. AFAIK, the main (only?) difference between "" and <> is that the
former implicitly adds the directory of the file containing the #include
directive to the search path (as the very first entry), which isn't
needed in this case.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160720/61612ce2/attachment.sig>