[Mesa-dev] [PATCH 05/15] ddebug: use a debug context for GPU hang debugging only

[Nicolai Hähnle]

On 23.07.2016 02:14, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> ---
>  src/gallium/drivers/ddebug/dd_screen.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/ddebug/dd_screen.c b/src/gallium/drivers/ddebug/dd_screen.c
> index 46869ab..d4a50ac 100644
> --- a/src/gallium/drivers/ddebug/dd_screen.c
> +++ b/src/gallium/drivers/ddebug/dd_screen.c
> @@ -116,7 +116,8 @@ dd_screen_context_create(struct pipe_screen *_screen, void *priv,
>     struct dd_screen *dscreen = dd_screen(_screen);
>     struct pipe_screen *screen = dscreen->screen;
>
> -   flags |= PIPE_CONTEXT_DEBUG;
> +   if (dscreen->mode == DD_DETECT_HANGS)
> +      flags |= PIPE_CONTEXT_DEBUG;

I don't like this change. Dumping command buffers with the 
GALLIUM_DDEBUG=always option has helped me find state tracking bugs.

Nicolai

>
>     return dd_context_create(dscreen,
>                              screen->context_create(screen, priv, flags));
>